Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-14025 Add new request to find existing transactions in database and their status #1238

Merged
merged 17 commits into from
Oct 5, 2023

Conversation

nkovacsx
Copy link
Contributor

@nkovacsx nkovacsx commented Sep 6, 2023

Overview

Adding a new request to the UTXO ledger layer to fetch transaction alongside with their status.

This is needed when doing a back-chain resolution. We don't want to fetch transactions that are already present in our database. We just want to fetch their IDs though, no need to deserialise the whole object.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 6, 2023

Jenkins build for PR 1238 build 14

Build Successful:
Jar artifact version produced by this PR: 5.1.0.29-alpha-1696513347352

@nkovacsx nkovacsx marked this pull request as ready for review September 6, 2023 11:36
vlajos
vlajos previously approved these changes Sep 14, 2023
Copy link
Contributor

@vlajos vlajos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a sync, but otherwise, LGTM.

@nkovacsx nkovacsx requested a review from vlajos September 21, 2023 07:31
vlajos
vlajos previously approved these changes Sep 21, 2023
Copy link
Contributor

@vlajos vlajos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(PR's title is outdated a bit.)

@nkovacsx nkovacsx changed the title CORE-14025 Add new request to find existing transactions in database with Verified/Unverified status CORE-14025 Add new request to find existing transactions in database and their status Sep 21, 2023
…nto nandor/CORE-14025/find-existing-tx-backchain
…nto nandor/CORE-14025/find-existing-tx-backchain
@nkovacsx nkovacsx requested a review from a team as a code owner October 4, 2023 15:22
@nkovacsx nkovacsx requested a review from vlajos October 5, 2023 12:55
lankydan
lankydan previously approved these changes Oct 5, 2023
@nkovacsx nkovacsx requested a review from lankydan October 5, 2023 13:42
@nkovacsx nkovacsx merged commit c071e61 into release/os/5.1 Oct 5, 2023
1 check passed
@nkovacsx nkovacsx deleted the nandor/CORE-14025/find-existing-tx-backchain branch October 5, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants